Pushed Healing Touch fixes and Youthful Brewmaster
These commits are going to get worse the later this goes
For Tree of Life, can I just heal everybody for 30 (it won't cause overheal - you have the health capped at 30 when healing or no)
You could do that but that wouldn't be correct behavior for a case like Auchenai Shadowpriest. I think you shouldn't skimp out on the 1 line of code to get the amount of missing health.
Extremely lazy Tree of Life and Poison Seeds pushed
I checked Healbot and others but didn't see checks on player health before healing
& Poison Seeds - those two lists should probably be combined but I don't write C#
How's this
{
MinionBoard[] boards = { spell.player.opponent.board, spell.player.board };
foreach (MinionBoard board in boards)
{
foreach (Minion m in board)
{
TransformMinion(spell.match, m, Card.Cardname.Treant);
}
}
}Tree of life heals minions too.
Poison seeds DESTROYS minions, which means their deathrattles would trigger. You are essentially doing mass Polymorph which is wrong.
Good points
Gotta sleep I am getting sloppy
I believe this is handled in the gamelogic heal function, not in individual healing cards.
How's this for minions under tree of health
MinionBoard[] boards = { spell.player.opponent.board, spell.player.board };
foreach (MinionBoard board in boards)
{
foreach (Minion m in board)
{
SetHealth(spell.match, m, m.maxHealth);
}
```Are you trolling me
2 Likes
Need this linted ASAP so I can go to bed
Edit: Literally just Heal(m, m.maxHealth - m.health, spell)
- Note that this spell's Summon effect takes place following the destruction of the minions. This means that Deathrattles will resolve while there are no minions on the board, reducing or entirely countering the effects of minions such as
Abomination and
Order of events
- Along with
Mimiron's Head,
Reincarnate and
Yogg-Saron, Hope's End, these cards utilize the Forced Death Phase mechanic to resolve deaths in the middle of a Phase, rather than at the end of the Phase.[1] This is in order to make room for the Treants to be summoned.
Was thinking about this
In this case we wrap the loop in midPhase and then resolve triggers after?
No. You mark all the minions as Dead, resolve triggers with no midphase, then call SummonToken for each minion destroyed.
Really what's funny is that I could get all the cards in the game done in a day or two - but this is a lot better.
1 Like
Won't resolve triggers trigger deathrattle before spawning treant
That's the point. Read the quote again.
I see. Two loops
Should be correct. For both
Maybe the first minion loop needs midphase wrapper so that eg. sylvanas doesn't steal an enemy minion while all minions are being destroyed
@Marie I just noticed that you were queueing earlier, didn't realize you were still going.
If you just leave the queue on you will get a lot of games, there are many people that have hopped in and out inbetween you opening and closing the game.
There is a notification sound for the queue pop.