My fork is up to date, it's something on your side
Considering I copied the mad bomber code you wrote for the 2 drops update into the arcane missiles implementation
Not sure why it broke the poison seeds code again on my side. There's still a lot of other syntax errors though that mostly come from calling functions wrong.
This is poison seeds implementation on my screen
Here's what I did to update - click "sync fork" on my fork after your commit 266 (" fix carddef + fatigue 1 display")
Syncs your main to my main
Then git pull main to my local - pulls latest main from my own repo (which is synced to your repo)
Then pushed that
I see since then 2 commits from you, 1 for art and 1 for deck prefab
Can you show the poison seeds code on your screen
I have already fixed them. Again.
1 Like
Poison seeds code in your main branch on gh
Matches mine
Regardless: When you open a PR it shows what the diff is so if I had something different for poison seeds it would show there in the PR
I think you just made some error with git
Probably what happened is you fixed & didn't push a change
Whatever happened I just had to manually write the fix for it and the rest of your broken syntax.
You really need to stop expecting me to fix the most mundane shit like this
Looks fine on my side - must be a local error that you're getting that little red squiggly thing
btw I made a very minor refactor to the removes logic here, I won't push it, you can just take it yourself if you like it
I think the list.add and then iterate list is all unnecessary, you can just remove directly
- There is no definition for the list "minions" in this function. You called it targets instead.
- You can't remove elements during a foreach loop, c# gives an error.
1 Like
Looks like that was a lie -
One more faulty PR and you're getting permanently banned. This is your final warning.
2 Likes
Whatever tempo mage list you're trying to make is still missing a lot of cards too tbh. Flamewalker, Fire cannon, Portal (banned card), to name a few.
Missing a period at the end of "Taunt."
1 Like
I'm actually enjoying writing code with no linter and no local environment / IDE plugins set up
Might switch to writing all my code in the github online editor next
You really learn a lot faster this way. This is how they used to do it when the first computers were being invented.
You're never going to learn that MinionBoard.Count() is a function and not a property like List.Count, so I'm actually just going to change it into a property instead. Half your errors are that.
I don't want to add any of those cards as I don't think they belong in the game
This deck is meant to be weak, it's not meant to have all the garbage they added later to make it competitive
Thanks for accommodating. I feel like we are learning to work together really well.
1 Like
If you want to add weak decks as a joke go ahead, but nobody enjoys playing against those either.
Sometimes the price of creative deckbuilding is that your decks are actually worse than the meta decks, but they're more rewarding because they're creative and each win feels that much better because the wins are so few and far between.